Skip to content

perf: read class attribute directly in selector adapter #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WebReflection merged 1 commit into from
Oct 9, 2026
Merged

perf: read class attribute directly in selector adapter #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cjs/shared/matches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const existsOne = (test, elements) => elements.some(
);

const getAttributeValue = (element, name) => name === 'class' ?
element.classList.value : element.getAttribute(name);
(element.getAttributeNode('class')?.value ?? null) : element.getAttribute(name);

const getChildren = ({childNodes}) => childNodes;

Expand Down
2 changes: 1 addition & 1 deletion esm/shared/matches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const existsOne = (test, elements) => elements.some(
);

const getAttributeValue = (element, name) => name === 'class' ?
element.classList.value : element.getAttribute(name);
(element.getAttributeNode('class')?.value ?? null) : element.getAttribute(name);

const getChildren = ({childNodes}) => childNodes;

Expand Down
7 changes: 7 additions & 0 deletions test/html/document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,13 @@ assert((new DocumentFragment).baseURI, null);
const {document: svg} = (new DOMParser).parseFromString('<svg class="foo-1"/>', 'text/html').defaultView.window;
assert(svg.querySelector('[class*="foo-"]'), svg.firstElementChild);

const {document: emptyClass} = parseHTML('<div><p id="a" class=""></p><p id="b"></p><svg><rect id="c" class=""/><rect id="d"/></svg></div>');
assert(emptyClass.querySelectorAll('[class=""]').map(({id}) => id).join(','), 'a,c', '[class=""] only matches empty class attributes');
emptyClass.getElementById('a').removeAttribute('class');
emptyClass.getElementById('b').className = 'x';
emptyClass.getElementById('b').classList.remove('x');
assert(emptyClass.querySelectorAll('[class=""]').map(({id}) => id).join(','), 'b,c', '[class=""] follows class mutations');

assert((new DOMParser).parseFromString('...', 'text/html').firstElementChild.localName, 'html');

const issue187 = (new DOMParser).parseFromString(`<!DOCTYPE html><html><head></head><body></body></html>`, 'text/html').defaultView.window.document;
Expand Down
Loading