Skip to content

fix: keep text elements' content out of attribute values (#341) #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vsolano9 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: keep text elements' content out of attribute values (#341) #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
009376b
fix: keep text elements' content out of attribute values (#341)
vsolano9 Oct 16, 2026
7048b60
fix: return a self-closed text element clone unchanged
vsolano9 Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cjs/html/text-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@ class TextElement extends HTMLElement {

toString() {
const outerHTML = toString.call(this.cloneNode());
return outerHTML.replace('><', () => `>${this.textContent}<`);
/* c8 ignore next */
if (outerHTML.endsWith(' />')) return outerHTML; // self-closed, as in XML documents
// the text goes before the end tag, as attribute values can contain "></" too
const end = outerHTML.lastIndexOf('></') + 1;
return outerHTML.slice(0, end) + this.textContent + outerHTML.slice(end);
}
}
exports.TextElement = TextElement
6 changes: 5 additions & 1 deletion esm/html/text-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ export class TextElement extends HTMLElement {

toString() {
const outerHTML = toString.call(this.cloneNode());
return outerHTML.replace('><', () => `>${this.textContent}<`);
/* c8 ignore next */
if (outerHTML.endsWith(' />')) return outerHTML; // self-closed, as in XML documents
// the text goes before the end tag, as attribute values can contain "></" too
const end = outerHTML.lastIndexOf('></') + 1;
return outerHTML.slice(0, end) + this.textContent + outerHTML.slice(end);
}
}
6 changes: 5 additions & 1 deletion worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8482,7 +8482,11 @@ class TextElement extends HTMLElement {

toString() {
const outerHTML = toString.call(this.cloneNode());
return outerHTML.replace('><', () => `>${this.textContent}<`);
/* c8 ignore next */
if (outerHTML.endsWith(' />')) return outerHTML; // self-closed, as in XML documents
// the text goes before the end tag, as attribute values can contain "></" too
const end = outerHTML.lastIndexOf('></') + 1;
return outerHTML.slice(0, end) + this.textContent + outerHTML.slice(end);
}
}

Expand Down