Isolate unreadable marker fixtures across target frameworks - #5035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finally.Root cause
The fixture previously lived beneath the test assembly's current directory. During a default multi-target run, one target framework could recursively enumerate another target's
bintree while the latter intentionally held itssecretdirectory unreadable. Filteringbin/objafter recursive enumeration was too late to prevent the access failure.Validation
dotnet build CodeIndex.sln -c Release -p:UseSharedCompilation=false --no-restoredotnet test --no-restore --nologo -p:UseSharedCompilation=falsedotnet run --project tools/CodeIndex.Changelog -- checkcdidx status --check --jsonorigin/main..HEADDocumentation and changelog
TESTING_GUIDE.mdin English and Japanese.changelog.d/unreleased/5019.internal.md.CHANGELOG.md.Follow-up
Fixes #5019