Fix false positive for files with only require_once and class definitions - #1369
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Thanks @GeorgeWebDevCy for your contribution. You need to review the tests that are failing before we can review the PR. |
|
Thanks for the heads up. I reviewed the failing tests and pushed a follow-up fix in 3813175. The CI matrix is now passing. |
| uses: codecov/codecov-action@fb8b3582c8e4def4969c97caa2f19720cb33a72f | ||
| with: | ||
| file: build/logs/*.xml | ||
| files: build/logs/*.xml |
There was a problem hiding this comment.
This updates the input name for the pinned Codecov action. At commit fb8b3582c8e4def4969c97caa2f19720cb33a72f, the action defines files (a comma-separated list of explicit coverage files) and passes it through as INPUT_FILES; it does not define a file input. Both occurrences use the same build/logs/*.xml pattern, so this makes the workflow use the action's supported input without changing which reports we intend to upload.
Fixes #1361