Build/Test Tools: Update the sinon dependency to version 22.0.0.#12388
Build/Test Tools: Update the sinon dependency to version 22.0.0.#12388tan7vir wants to merge 1 commit into
Conversation
Update sinon from 16.1.3 to 22.0.0 and regenerate the lockfile. Adjust the communityEvents.getTimeZone QUnit tests in tests/qunit/wp-admin/js/dashboard.js to stub the Intl.DateTimeFormat constructor, since sinon 17+ (via @sinonjs/fake-timers Intl mirroring) no longer intercepts prototype-level resolvedOptions() stubs on freshly constructed instances. See #64228.
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @tan7vir. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This updates the
sinondevelopment dependency from 16.1.3 to the latest 22.0.0, as requested on the ticket, and regeneratespackage-lock.json.sinon-testandqunitare left unchanged, and the lockfile changes are confined to thesinondependency subtree.The bump surfaces the timezone test failures noted on the ticket. The
communityEvents.getTimeZonetests intests/qunit/wp-admin/js/dashboard.jsstubbedIntl.DateTimeFormat.prototype.resolvedOptions, butgetTimeZone()reads from a freshly constructedIntl.DateTimeFormat()instance. From sinon 17 onwards, the bundled@sinonjs/fake-timersmirrorsIntlinside the sandbox, so a newly constructed instance no longer resolves to the prototype-level stub.The tests are updated to replace the
Intl.DateTimeFormatconstructor viasinon.replace()(the ticket's suggestedsinon.stub( Intl, 'DateTimeFormat' )throws against the mirroredIntl), and to restore the sandbox at the end of each test to match the convention used elsewhere in the file. No production code is changed.Testing:
npm run grunt qunit:compiledreports 535/535 passing (0 failed) on bothcompiled.htmlandindex.html. Before the change, the four documentedgetTimeZoneassertions fail.Trac ticket: https://core.trac.wordpress.org/ticket/64228
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 4.8
Used for: Analysing the sinon major-version breaking changes and the
@sinonjs/fake-timersIntlmirroring behaviour, drafting the dependency update and the test adjustments, and running the QUnit suite. All changes were reviewed, tested, and are owned by me.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.