Skip to content

Admin: Use absolute URLs in admin menu links#12397

Open
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-56302-admin-menu-absolute-urls
Open

Admin: Use absolute URLs in admin menu links#12397
ArkaPrabhaChowdhury wants to merge 2 commits into
WordPress:trunkfrom
ArkaPrabhaChowdhury:trac-56302-admin-menu-absolute-urls

Conversation

@ArkaPrabhaChowdhury

Copy link
Copy Markdown

Trac ticket: https://core.trac.wordpress.org/ticket/56302

This updates admin menu rendering so generated menu item href values use absolute URLs in the current admin context, while preserving already absolute/external URLs.

Validation:

  • php -l src\wp-admin\menu-header.php
  • php -l tests\phpunit\tests\admin\menuHeader.php
  • php vendor\squizlabs\php_codesniffer\bin\phpcbf --standard=phpcs.xml.dist src\wp-admin\menu-header.php tests\phpunit\tests\admin\menuHeader.php
  • php vendor\squizlabs\php_codesniffer\bin\phpcs --standard=phpcs.xml.dist src\wp-admin\menu-header.php tests\phpunit\tests\admin\menuHeader.php
  • git diff --check

Note: Focused PHPUnit could not run locally because the configured test DB host \mysql\ is unavailable and Docker Desktop is not running on this machine.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@ArkaPrabhaChowdhury ArkaPrabhaChowdhury marked this pull request as ready for review July 3, 2026 10:19
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props arkaprabhachowdhury.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant