Skip to content

Site Health: Detect an OPcache file cache as an enabled opcode cache - #13206

Open
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65921-opcache-file-cache-detection
Open

Site Health: Detect an OPcache file cache as an enabled opcode cache#13206
itzmekhokan wants to merge 1 commit into
WordPress:trunkfrom
itzmekhokan:fix/65921-opcache-file-cache-detection

Conversation

@itzmekhokan

Copy link
Copy Markdown

Site Health reports "Opcode cache is not enabled" on servers running OPcache with opcache.file_cache_only turned on, even though a file-based opcode cache is active.

get_test_opcode_cache() treats opcache_get_status()['opcache_enabled'] as the only signal, but OPcache sets that flag to false in file-cache-only mode and instead exposes a file_cache_only key. The patch accepts either signal. That key is present only when the file cache is the active backend, so shared memory configurations are unchanged.

The change only widens what counts as enabled, so no configuration that currently passes can start failing.

Trac ticket: https://core.trac.wordpress.org/ticket/65921

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Investigating the OPcache behaviour, drafting the one-line fix, and updating the existing test's environment check. All changes were reviewed and validated by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

`opcache_get_status()` reports `opcache_enabled` as false when OPcache
runs with `opcache.file_cache_only` enabled, even though the file cache
is an active opcode cache. `get_test_opcode_cache()` therefore reported
"Opcode cache is not enabled" on those configurations.

Treat the `file_cache_only` flag in the status array as an enabled
opcode cache. The flag is only present when the file cache is the
active backend, so shared memory configurations are unaffected.

Fixes #65921.
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props khokansardar.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant