Build/Test Tools: Flag slow PHPUnit tests with annotations by lancewillett · Pull Request #13212 · WordPress/wordpress-develop

lancewillett · 2026-08-20T23:54:33Z

Trac ticket: https://core.trac.wordpress.org/ticket/65887

What this changes

Adds a Flag slow PHPUnit tests step to the canonical PHP 8.5 report job. It parses the JUnit report and, for tests over a threshold (default 1s), emits GitHub Actions warning annotations and a run-summary table naming the slowest tests. Runs on pull requests and pushes to trunk.

This complements #13083: those six CodeVitals aggregates store the trend but cannot name a test. This one names the slow ones, so a PR author can spot a slow test they added.

Behavior

Advisory only: runs even on failed test runs (always()) and never fails the build (continue-on-error).
Inline annotations capped at 10 (GitHub's per-step limit); the summary table lists more.
Container-absolute paths normalized to repository-relative so annotations resolve.
A testcase without timing data (e.g. a skipped test) is ignored, not an error.

Use of AI Tools

AI assistance: Yes
Tool(s): Codex (via Claude Code), hardened with an adversarial multi-lens review
Used for: drafting the workflow step and PHP script, and reviewing it before submission.

Parse the JUnit report from the canonical PHP 8.5 report job and emit GitHub Actions warning annotations plus a run-summary table for tests over a threshold, on pull requests and pushes to trunk. Advisory only: the step runs even on failed test runs and never fails the build itself. This names the slow tests, complementing the aggregate CodeVitals trend that stores them without naming any one test. See #65887.

github-actions · 2026-08-20T23:54:43Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @lance.willett@a8c.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

github-actions · 2026-08-20T23:58:00Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot

Pull request overview

This PR adds CI tooling to surface individual slow PHPUnit tests during GitHub Actions runs by parsing the generated JUnit report and emitting GitHub Actions warning annotations plus a step-summary Markdown table, targeting the canonical PHP 8.5 reporting job context.

Changes:

Added a new PHP CLI script to parse junit.xml, identify tests exceeding a configurable threshold, and emit warning annotations and a run summary.
Integrated a new “Flag slow PHPUnit tests” step into the reusable PHPUnit workflow (gated to PHP 8.5 + reporting-enabled runs on PRs and trunk pushes).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
`tests/phpunit/prepare-slow-test-annotations.php`	New CLI parser that finds slow testcases in JUnit XML and outputs GitHub Actions annotations + a step summary table.
`.github/workflows/reusable-phpunit-tests-v3.yml`	Adds a workflow step that runs the new parser after the main PHPUnit run under the intended conditions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+        if: >-
+          always() && inputs.report && inputs.php == '8.5' &&
+          ( github.event_name == 'pull_request' ||
+            ( github.event_name == 'push' && github.ref == 'refs/heads/trunk' ) )


adimoldovan

One PHPCS error fails the build. The rest are small.

Two points that map to no line in the diff:

#13083 adds class-wp-phpunit-timing-metrics.php, which streams the same junit.xml at the same point in the same workflow. Once it lands, this script should reuse it rather than walk the file a second time.
The job's # Performs the following steps: list (lines 110-129) omits this step. #13083 updates that list for its own step.

adimoldovan · 2026-08-21T12:59:09Z

+		"Usage: php tests/phpunit/prepare-slow-test-annotations.php <junit-file> "
+		. "[threshold-seconds] [max-annotations]\n"


This fails the build. The string holds no variable and no escape, so Squiz.Strings.DoubleQuoteUsage rejects the double quotes. Coding standards / PHP checks is the only red check on the PR.

Suggested change

"Usage: php tests/phpunit/prepare-slow-test-annotations.php <junit-file> "

. "[threshold-seconds] [max-annotations]\n"

'Usage: php tests/phpunit/prepare-slow-test-annotations.php <junit-file> '

. "[threshold-seconds] [max-annotations]\n"

adimoldovan · 2026-08-21T12:59:09Z

+		}
+	);
+
+	$slow_tests = array_slice( $slow_tests, 0, $max_annotations );


The max-annotations argument caps the summary table, not the annotations, which line 214 caps separately at 10. The name says the opposite of what the value does. The table then stops at 20 rows with no marker, so it reads as complete when it is not.

adimoldovan · 2026-08-21T12:59:09Z

+		if ( '' !== $test['file'] ) {
+			$properties[] = 'file=' . wp_phpunit_escape_command_property( $test['file'] );
+		}
+
+		if ( '' !== $test['line'] ) {
+			$properties[] = 'line=' . wp_phpunit_escape_command_property( $test['line'] );
+		}


A testcase with line and no file emits ::warning line=60,..., which GitHub ignores. PHPUnit sets both together from reflection, so this branch never fires on a real report — tidying only.

Suggested change

if ( '' !== $test['file'] ) {

$properties[] = 'file=' . wp_phpunit_escape_command_property( $test['file'] );

}

if ( '' !== $test['line'] ) {

$properties[] = 'line=' . wp_phpunit_escape_command_property( $test['line'] );

}

if ( '' !== $test['file'] ) {

$properties[] = 'file=' . wp_phpunit_escape_command_property( $test['file'] );

if ( '' !== $test['line'] ) {

$properties[] = 'line=' . wp_phpunit_escape_command_property( $test['line'] );

}

}

adimoldovan · 2026-08-21T12:59:09Z

+        # Runs even when the test step failed (always()), so the signal still
+        # surfaces on red runs, and never fails the job itself (continue-on-error),
+        # because this is advisory only.
+        if: >-


always() also runs the step on cancelled jobs, and phpunit-tests.yml sets cancel-in-progress: true, so PR runs are cancelled often. !cancelled() matches the intent.

lancewillett requested a review from adimoldovan August 20, 2026 23:54

lancewillett mentioned this pull request Aug 21, 2026

Build/Test Tools: Preserve PHPUnit timing results for use in metrics #13070

Open

lancewillett requested review from desrosj and a lite review from Copilot August 21, 2026 00:42

Copilot started reviewing on behalf of lancewillett August 21, 2026 00:42 View session

lancewillett mentioned this pull request Aug 21, 2026

Build/Test Tools: Publish PHPUnit timing metrics to CodeVitals #13083

Open

Copilot AI reviewed Aug 21, 2026

View reviewed changes

Comment thread .github/workflows/reusable-phpunit-tests-v3.yml

Comment on lines +276 to +279

if: >-

always() && inputs.report && inputs.php == '8.5' &&

( github.event_name == 'pull_request' ||

( github.event_name == 'push' && github.ref == 'refs/heads/trunk' ) )

adimoldovan suggested changes Aug 21, 2026

View reviewed changes

Navigation Menu

Uh oh!

Build/Test Tools: Flag slow PHPUnit tests with annotations - #13212

Build/Test Tools: Flag slow PHPUnit tests with annotations#13212
lancewillett wants to merge 1 commit into
WordPress:trunkfrom
lancewillett:feat/65887-flag-slow-phpunit-tests

lancewillett commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

adimoldovan left a comment

Uh oh!

adimoldovan Aug 21, 2026

Uh oh!

adimoldovan Aug 21, 2026

Uh oh!

adimoldovan Aug 21, 2026

Uh oh!

adimoldovan Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		"Usage: php tests/phpunit/prepare-slow-test-annotations.php <junit-file> "
		. "[threshold-seconds] [max-annotations]\n"

Uh oh!

Conversation

lancewillett commented Aug 20, 2026

What this changes

Behavior

Use of AI Tools

Uh oh!

github-actions Bot commented Aug 20, 2026

Unlinked Accounts

Uh oh!

github-actions Bot commented Aug 20, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

adimoldovan left a comment

Choose a reason for hiding this comment

Uh oh!

adimoldovan Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

adimoldovan Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

adimoldovan Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

adimoldovan Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants