Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This override has been mapped to be equivalent to `:focus-visible`, which also changes how it operates, modifying the text color rather than ring color. This causes any support to result in transparent text in high contrast mode
…press-develop into whcm-focus-styles
|
I'm inclined to handle the adminbar issue separately, as it will require some more significant adjustments, and is a different class of problem than the others. |
|
Test ping to @joedolson |
Code ReviewTested and reviewed PR #13944 across Chrome and Firefox with The implementation is solid:
Two small observations to finalize this PR:
|
In progress ticket to fix issues with Windows High Contrast Mode focus styling.
-moz-focusringcauses transparent text in select elements on focus. The pseudoclass has been mapped to equate tofocus-visible, and shows as that in the inspector; this changed how it impacts the element, and needs to be removed.Trac ticket: https://core.trac.wordpress.org/ticket/45910
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.