Skip to content

TinyMCE: Replace deprecated unload listener with pagehide - #14775

Open
Sukhendu2002 wants to merge 1 commit into
WordPress:trunkfrom
Sukhendu2002:fix/62924-tinymce-unload
Open

Sukhendu2002 wants to merge 1 commit into
WordPress:trunkfrom
Sukhendu2002:fix/62924-tinymce-unload

Conversation

@Sukhendu2002

Copy link
Copy Markdown

TinyMCE registers an unload listener when its selector engine switches to an iframe document. Chromium browsers deprecate or block this listener, producing console warnings when using the Classic block or Classic Editor.

Replace unload with pagehide in both tinymce.js and tinymce.min.js, preserving the callback that resets the selector engine’s document reference.

Update both revision headers and bump $tinymce_version to invalidate cached scripts.

Trac ticket: https://core.trac.wordpress.org/ticket/62924

Use of AI Tools

AI assistance: Yes
Tool(s): Codex
Model(s): GPT 6.1 sol
Used for: Focused browser verification, code review, and PR description drafting; final implementation and tests were reviewed and edited by me.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@Sukhendu2002
Sukhendu2002 marked this pull request as ready for review October 23, 2026 09:58
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant