Skip to content

Tests: Make data providers in shortcode.php static #14793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shail-mehta wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Tests: Make data providers in shortcode.php static #14793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/phpunit/tests/shortcode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,7 @@ public function test_strip_shortcodes( $expected, $content ) {
$this->assertSame( $expected, strip_shortcodes( $content ) );
}

public function data_strip_shortcodes() {
public static function data_strip_shortcodes() {
return array(
array( 'before', 'before[gallery]' ),
array( 'after', '[gallery]after' ),
Expand Down Expand Up @@ -547,7 +547,7 @@ public function test_escaping( $input, $output ) {
return $this->assertSame( $output, do_shortcode( $input ) );
}

public function data_escaping() {
public static function data_escaping() {
return array(
array(
'<!--[if lt IE 7]>',
Expand Down Expand Up @@ -625,7 +625,7 @@ public function test_escaping2( $input, $output ) {
return $this->assertSame( $output, strip_shortcodes( $input ) );
}

public function data_escaping2() {
public static function data_escaping2() {
return array(
array(
'<!--[if lt IE 7]>',
Expand Down Expand Up @@ -700,7 +700,7 @@ private function sub_registration( $input, $expected ) {
$this->assertSame( $expected, $actual );
}

public function data_registration_bad() {
public static function data_registration_bad() {
return array(
array(
'<html>',
Expand Down Expand Up @@ -733,7 +733,7 @@ public function data_registration_bad() {
);
}

public function data_registration_good() {
public static function data_registration_good() {
return array(
array(
'good!',
Expand Down Expand Up @@ -761,7 +761,7 @@ public function test_pcre_performance( $input ) {
return $this->assertLessThan( 200, $result );
}

public function data_whole_posts() {
public static function data_whole_posts() {
require_once DIR_TESTDATA . '/formatting/whole-posts.php';
return data_whole_posts();
}
Expand Down
Loading