Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Adds a fourth
$is_trimmedargument to theget_comment_excerptfilter so callbacks can tell whether the comment text was shortened to build the excerpt, without checking for a trailing…(which misfires on comments that genuinely end in an ellipsis).Changes
get_comment_excerpt()derives the flag by runningwp_trim_words()a second time with an empty$moreand comparing the result to the real excerpt. This reuseswp_trim_words()'s own counting rules, including character-based locales, instead of duplicating them.$is_trimmedparameter with@since 7.2.0.dev-feedbackdiscussion on top of the earlier switch towp_trim_words()(the old patch no longer applies because the$use_ellipsisvariable is gone).Tests
Known edge case
wp_trim_words()call fires thewp_trim_wordsfilter a second time. A third-party filter that discards$moreand rebuilds the text could make the flag reportfalsefor a trimmed comment.Trac ticket: https://core.trac.wordpress.org/ticket/43792
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for details.
🤖 Generated with Claude Code