Skip to content

Comments: Pass an $is_trimmed argument to the get_comment_excerpt filter - #14794

Open
irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:enhancement/43792-get-comment-excerpt-filter-is-trimmed
Open

irozum wants to merge 1 commit into
WordPress:trunkfrom
irozum:enhancement/43792-get-comment-excerpt-filter-is-trimmed

Conversation

@irozum

@irozum irozum commented Oct 23, 2026

Copy link
Copy Markdown

Adds a fourth $is_trimmed argument to the get_comment_excerpt filter so callbacks can tell whether the comment text was shortened to build the excerpt, without checking for a trailing … (which misfires on comments that genuinely end in an ellipsis).

Changes

  • get_comment_excerpt() derives the flag by running wp_trim_words() a second time with an empty $more and comparing the result to the real excerpt. This reuses wp_trim_words()'s own counting rules, including character-based locales, instead of duplicating them.
  • The hook docblock documents the new $is_trimmed parameter with @since 7.2.0.
  • Appending a filter argument is backward compatible: callbacks registered with fewer accepted args are unaffected.
  • This resolves the remaining ask from the dev-feedback discussion on top of the earlier switch to wp_trim_words() (the old patch no longer applies because the $use_ellipsis variable is gone).

Tests

  • New data-provider test covering a long comment, a short comment, a word count equal to and above the limit, and a short comment that ends in an ellipsis.

Known edge case

  • The extra wp_trim_words() call fires the wp_trim_words filter a second time. A third-party filter that discards $more and rebuilds the text could make the flag report false for a trimmed comment.

Trac ticket: https://core.trac.wordpress.org/ticket/43792

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Sonnet 5.5
Used for: Implementation, tests, and PR description.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for details.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props irozum.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant