Repository navigation
Conversation
…uring REST requests.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the REST clause in
WP_Query::parse_query():( wp_is_serving_rest_request() && $this->is_main_query() ). This is a test-only change and adds no production behaviour.Trac ticket: https://core.trac.wordpress.org/ticket/50213
Follow-up to [48053], which restricted the REST exemption to the main query so that secondary queries can still be
is_home. The ticket was closed as fixed withneeds-unit-testsstill set, and nothing intests/phpunitcovered it.What is tested (
Tests_Query_ParseQuery)test_secondary_query_during_rest_request_can_be_home: withREST_REQUESTtrue, a query that is not$wp_the_queryhasis_home === true.test_main_query_during_rest_request_is_not_home: withREST_REQUESTtrue, the query that is$wp_the_queryhasis_home === false.Why these cases
is_main_query()condition added in [48053]. Each test asserts a precondition onis_main_query()so a setup mistake can't pass silently.REST_REQUESTis a constant, so both tests use@runInSeparateProcesswith@preserveGlobalState disabled, aswpIsServingRestRequest.phpdoes.Verification
&& $this->is_main_query()makes only the secondary-query test fail.Tests_Query_ParseQuerypasses (19 tests) and PHPCS reports no errors or warnings on the file.Use of AI Tools
This change was written with Claude Code (Claude Sonnet 5.5), which drafted the tests and ran the verification above.
This PR is for code review only. Please do not merge it from GitHub; commits happen through Trac.