Repository navigation
Tests: Make data provider in getLastCommentModified.php static - #14801
Draft
shail-mehta wants to merge 1 commit into
Draft
shail-mehta wants to merge 1 commit into
shail-mehta wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The provider has no instance-state dependencies, so the static declaration preserves its behavior and existing test usage.
No open issues 🎉
What changed in this PR
This test-only change makes a comment test data provider static, aligning it with PHPUnit data-provider requirements without changing production code.
Changes:
- Declares
data_internal_comment_types_are_excluded()aspublic static, preserving its literal datasets and existing test reference.
| File | Description |
|---|---|
tests/phpunit/tests/comment/getLastCommentModified.php |
Makes the data provider static for PHPUnit compatibility. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Trac ticket: #65819
Makes the data provider in
tests/phpunit/tests/comment/getLastCommentModified.phpstatic.Why
PHPUnit data providers should be static so they do not depend on test instance state and remain compatible with current PHPUnit usage in Core.
How
data_internal_comment_types_are_excluded()topublic staticTest-only; no production code changes.
Testing Instructions
npm run test:php -- --filter Tests_Comment_GetLastCommentModifiednpm run test:php -- --filter Tests_Comment_GetLastCommentModified -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_Comment_GetLastCommentModified --order-by=randomnpm run test:php -- --group commentUse of AI Tools