Skip to content

Tests: Make data providers in locale.php static - #14806

Draft
shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/65819-static-data-providers-locale
Draft

shail-mehta wants to merge 1 commit into
WordPress:trunkfrom
shail-mehta:tests/65819-static-data-providers-locale

Conversation

@shail-mehta

Copy link
Copy Markdown
Member

What

Trac ticket: #65819

Makes the data providers in tests/phpunit/tests/locale.php static.

Why

PHPUnit data providers should be static so they do not depend on test instance state and remain compatible with current PHPUnit usage in Core.

How

  • Convert data_property_initializes_to_array() to public static
  • Convert data_get_word_count_type() to public static

Test-only; no production code changes.

Testing Instructions

  1. npm run test:php -- --filter Tests_Locale
  2. npm run test:php -- --filter Tests_Locale -c tests/phpunit/multisite.xml
  3. npm run test:php -- --filter Tests_Locale --order-by=random
  4. npm run test:php -- --group l10n

Use of AI Tools

  • Cursor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Both providers are independent of instance state, and the declaration changes preserve their data and existing test references.

No open issues 🎉

What changed in this PR

Updates the locale tests’ data providers to be static, aligning them with current PHPUnit usage in WordPress Core.

Changes:

  • Makes data_property_initializes_to_array() and data_get_word_count_type() public static methods.
  • Preserves provider data and test behavior; no production code changes.
File Description
tests/​phpunit/​tests/​locale.php Adds static to both data provider declarations.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants