Skip to content

Tests: Make data providers in file.php static #14807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shail-mehta wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Tests: Make data providers in file.php static #14807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/phpunit/tests/file.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public function test_wp_tempnam( $filename ) {

$this->assertNotEmpty( basename( basename( $file, '.tmp' ), '.zip' ) );
}
public function data_wp_tempnam_filenames() {
public static function data_wp_tempnam_filenames() {
return array(
array( '0.zip' ),
array( '0.1.2.3.zip' ),
Expand Down Expand Up @@ -155,7 +155,7 @@ public function test_wp_tempnam_should_limit_filename_length_to_252_characters(
*
* @return array[]
*/
public function data_wp_tempnam_should_limit_filename_length_to_252_characters() {
public static function data_wp_tempnam_should_limit_filename_length_to_252_characters() {
return array(
'the limit before adding characters for uniqueness' => array( 'filename' => str_pad( '', 241, 'filename' ) ),
'one more than the limit before adding characters for uniqueness' => array( 'filename' => str_pad( '', 242, 'filename' ) ),
Expand Down
Loading