Repository navigation
Repair packaged first run and add Windows validation - #3
Merged
Merged
Conversation
Zacharon
marked this pull request as ready for review
October 13, 2026 05:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public.2 archive documents a relative demo output path that its traversal guard correctly rejects. This prepares the new unpublished
2026.10.12-public.4-candidate.1archive, resolves the destination to an absolute path in FIRST_RUN, and aligns README/site commands. Historical public.1/public.2 files and ZIPs, the separate public.3 candidate, rights notices and live download links remain untouched.Adds deterministic archive/manifest verification and a bounded Windows CPython 3.14.5 workflow that executes actual extracted-package instructions with a fresh virtual environment, resumes the result, runs the unchanged 86 regressions plus seven distribution regressions, and checks archive/path/public-link boundaries. Runtime Python and existing tests are byte-identical to public.2.
Initial hosted checks at 65398ba genuinely failed: the runner's short TEMP spelling caused 18 path-comparison errors in unchanged direct fixtures. The follow-up CI-only commit 647d496 resolves runner-owned RUNNER_TEMP and sets process-local TMP/TEMP. Guards, test cases and package bytes remain unchanged. Both failures are retained as evidence; no bypass or skipping was introduced.
Local validation through the corrected workflow block passed 93 tests without skips, fresh extraction/demo/resume and 82 local links. Independent read-only re-review of exact 647d496 reproduced the path mismatch and verified corrected child temp environment, unchanged parent environment and fail-before-continuation for missing RUNNER_TEMP. The independent verdict is retained as PARTIAL from review before hosted completion; owner required-check settings remain unapplied. Both corrected hosted runs have now passed, without self-upgrading H3. No local defect was identified.
This draft is a repair candidate. Merge, publication, live download links, private OS installation, hosted/human acceptance and required-check settings remain owner-controlled. No deployment workflow is added; actual CI at final SHA is tracked below. Broader transitive advisory auditing and upstream HTTP health remain outside this evidence.
Hosted runs at the current SHA: push validation and PR validation. Both completed SUCCESS at head 647d496: 93 tests, no skips, Windows Server 2025 and CPython 3.14.5. Push checked out the exact candidate; PR checked out synthetic merge 80ace7e with identical tree f042d4d10b329e6124ac1227bd4272bc39c439e3.