[Chore] Enforce safe async handling in core tools - #1255
Open
zoomote[bot] wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
Author
|
Addressed all five lines from Codecov's initial patch report with focused tests for parse errors, shell and cmd.exe fallbacks, command timeouts, and edited-todo ordering. Local coverage confirms each reported line is now exercised; the full lint, type-check, and test suites pass. Pushed in commit |
edelauna
marked this pull request as ready for review
August 15, 2026 22:26
edelauna
requested review from
JamesRobert20,
edelauna,
hannesrudolph,
navedmerchant and
taltas
as code owners
August 15, 2026 22:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
@typescript-eslint/no-floating-promisesratchet tocore/tools/**/*.tsand resolved all 20 existing findings in that scope.Why this change was made
Floating promises can create unhandled rejections, silent status-update failures, and ordering races in tool execution paths. Enforcing the rule in this directory prevents new instances while making the existing asynchronous intent explicit. The focused branch tests also cover every line identified by Codecov's initial patch report.
Impact
There is no intended user-facing workflow change. Core tool execution is more resilient to webview notification failures, async ordering is explicit, and future floating promises in this scope now fail lint.