Repository navigation

feat(editor): route the diff-view save through the guard (U8, #1375) - #1916

Open

easonLiangWorldedtech wants to merge 83 commits into

Zoo-Code-Org:mainfrom

easonLiangWorldedtech:fws/u8-diffview-guarded-save

Open

feat(editor): route the diff-view save through the guard (U8, #1375)#1916
easonLiangWorldedtech wants to merge 83 commits into
Zoo-Code-Org:mainfrom
easonLiangWorldedtech:fws/u8-diffview-guarded-save

Commits on Oct 14, 2026
- split unit U1 of PR 1833 (issue 1375)
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  7505c8e
- fix(file-safety): close the pre-merge findings on the publish primitive (U1, issue 1375)
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  1b07409
- fix(file-safety): propagate a non-ENOENT lstat failure in resolvePublishTarget (U1, issue 1375)
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  8735c49
- fix(file-safety): keep the rollback pair typed and the mock stand-ins type-sound
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  1fca597
- rebuild unit u2 on the fixed chain
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  4e74e82
- chore(lint): prune the safeWriteJson suppression this unit earns
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  815b5e0
- rebuild unit u3 on the fixed chain
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  ffa10b1
- fix(task): declare the observation registry on Task in this unit
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  4653b34
- rebuild unit u4 on the fixed chain
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  dfac2c3
- rebuild unit u5 on the fixed chain
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  fed1242
- rebuild unit U8 on U5 (corrected merge order)
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  27d98af
- chore(ci): rerun the e2e-mock lane
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  44dc7e1
- fix(file-safety): inherit unit 1 committed guard
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  91bd6c7
- test: rerun mocked e2e - no source change, previous run failed in the runner
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  0a7fcff
- fix(file-safety): keep the publish error message in RollbackFailureError
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  716b5d9
- test(file-safety): assert the exact staging directory removed after a rollback failure
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  c478fdc
- test: re-trigger required checks - the queued runs were cancelled by the Actions queue, no source change
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  02ce2e6
- test: re-run mocked e2e and the ubuntu lane - no source change since the last green run on these files
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  0aaf125
- test: re-run mocked e2e - the suite passed on the previous head of this branch and no source changed
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  930c88d
- fix(file-safety): give the Windows DACL dump a per-write name
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  f6b3e3d
- test: third mocked-e2e attempt on this unit - the suite is green on the other eight units of the same chain with the same guard behaviour
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  f4e03eb
- chore(ci): re-run mocked E2E (apply_diff timeouts on the previous run; this unit was green on the earlier run)
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  a5eaa7a
- chore(ci): second re-run of the mocked E2E suite. The apply_diff fixtures 404 on this run while the identical content passes on #1918, so the failure is in the mock fixture matching, not this unit'…
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  eb93e30
- fix(tools): apply_diff must publish with edit-guard semantics, not create semantics
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  1140140
- fix(file-safety): durable-copy publish and confined writes for the diff-view unit
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  0d3697d
- fix(file-safety): do not read a failed target lstat as a missing target
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  bb15ea9
- fix(file-safety): compare staging and target identity with bigint stats
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  8a86a91
- test(file-safety): pin the bigint options in the staging-identity tests
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  732bfff
- fix(file-safety): report a Windows replacement whose DACL was not preserved
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  ebfc7fb
- fix(diff-view): undo a partial open() instead of leaving an unapproved file
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  5b8fa7b
- fix(file-safety): route the DACL restore failure through onWarning too
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  d87e1d4
- fix(file-safety): keep DACL warning delivery from failing the save
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  90e4b22
- fix(utils): check confinement before taking the advisory lock
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  6f69ff6
- fix(integrations): the preview observation must not authorize an approved edit
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  0028a1b
- fix(file-safety): handle async warning sinks and confine before mkdir
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  da01ba8
- fix(tools): ApplyDiffTool must observe the version its diff was built on
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  1c6e5d3
- test(tools): type the apply_diff observation doubles for check-types
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  51137bf
- fix(integrations): never adopt an autosaved match for an unauthorized edit
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  26be948
- fix(tools): never refresh a model observation the tool read on a different version
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  2316165
- fix(editor): attribute an adopted publish to the version the preview saw
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  c508da8
- fix(u8): track placeholder ownership apart from the observation token
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  0f31b2d
- fix(file-safety): one lock key whether the parent directory exists yet
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  c868022
- test(file-safety): a backup copy that fails part-way must not survive the write
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  abf03c5
- fix(diff-view): put the save's post-publish cleanup inside the same teardown as a cancellation
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  9d2be1e
- fix(diff-view): let only the teardown that started a pass finalize the session
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  3a3473e
- test(file-safety): pin that an uncanonicalizable confined scope stops the write before the lock
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  c075439
- fix(diff-view): restore preview tabs for the pass that owns a rejected save, and pin the scope walk
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  56fb9cc
- test(apply-diff): cover the two bracketing stats that can fail on their own
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  8a29285
- fix(read-file): stop indenting the read content inside the notice templates
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  a8df293
- test(safe-write): a warning sink that throws must not fail the committed write
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  d1ca165
- fix(diff-view): finalize the session when a cancellation lands during a teardown it does not own
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  d564f61
- test(diff-view): put the rejected-publish comment back above the test it documents
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  db5ef0a
- fix(file-safety): never abandon the backup seed descriptor when its close fails
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  fdc1ace
- fix(diff-view): one caller owns the session's finalization, by claim rather than by reading state
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  34a88e4
- fix(safe-write): a write that declares no scope replaces the link instead of writing through it
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  bc8aeee
- fix(diff-view): the rejected-save pass owns the session through preview restoration
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  facbc4c
- fix(safe-write): an existing Windows target is not published over under an unknown or unverifiable ACL
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  f34215c
- fix(test): teach main's unicode-reader spec about hasClippedLines
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  7b1a20d
- fix(safe-write): every descriptor this call owns is released through the retry-and-report path
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  0b12594
- fix(safe-write): a failed Windows ACL step never publishes content, and a close is never attempted twice
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  e0fbde1
- fix(safe-write-json): an unscoped write locks and reads the file it actually replaces
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  95480b7
- fix(safe-write): match a verified ACE against the whole principal, not its account name
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  dc4a78a
- fix(diffview): put the finalization guard on the public reset(), not behind it
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  0942fd1
- fix(safe-write-json): keep the referent lock beside the link-path lock on an unscoped publish
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  87ac7b1
- style: format the ten files the formatting gate flags on this PR
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  51257de
- test: scope the icacls assertion to the platform that issues the command
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  516496a
- fix: fold a lock key from the deepest existing ancestor, not the way strings compare
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  fc6ef60
- fix(safe-write-json): take the lock on the canonical spelling of the link path
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  625d412
- style: reflow the lock-key spec to the repo's prettier output
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  56c45d6
- fix(u8): refuse adoption when the rejection was about completeness, and fix the ACL read-back parser
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  d2ce125
- fix(editor): reconcile the observation when a guarded publish lands without durability
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  05a5e1d
- fix(utils): decide confinement once and reject a declared-empty root
  
  easonLiangWorldedtech
  authored and
  easonLiangWorldedtech
  committed
  413fa01
- fix: order cancellation against the guarded publish and session restart
  
  easonliang28
  authored and
  easonLiangWorldedtech
  committed
  81d16f3
- test(diffview): keep the open() serialization test inside the lint suppression budget
  
  easonliang28
  authored and
  easonLiangWorldedtech
  committed
  2ba2936
- fix(diffview): gate the rollback against the rejected save's full lifecycle
  easonLiangWorldedtech
  committed
  716bff8
- fix(u8): align the unit with main's lint re-enable and format gate
  easonLiangWorldedtech
  committed
  0a76af3
- fix(integrations,file-safety): clear the re-review threads on typed tests, report counting and link backups
  easonLiangWorldedtech
  committed
  5a04426
- chore: retrigger CI (windows timing flake in main's TaskHistoryStore.realConcurrency spec, unrelated to unit)
  easonLiangWorldedtech
  committed
  9980ac7
- fix(file-safety): refuse a captured-DACL publish over a symbolic link before the commit
  easonLiangWorldedtech
  committed
  3624e4f
- test(utils): follow the DACL-over-link refusal in the lock-key integration specs
  easonLiangWorldedtech
  committed
  f23e49f
- test(task): prove per-Task observation registry ownership with real Tasks
  easonLiangWorldedtech
  committed
  c6b3e86
- fix(editor): withdraw the preview observation on every exit path (port)
  easonLiangWorldedtech
  committed
  82cfbf2
- fix(editor): narrow the preview task before the withdrawal forget
  easonLiangWorldedtech
  committed
  5622f24

Commits

Commits on Oct 14, 2026