Repository navigation
fix: make error hints match the error class - #107
Open
ConnorMoss02 wants to merge 1 commit into
Open
ConnorMoss02 wants to merge 1 commit into
ConnorMoss02 wants to merge 1 commit into
Conversation
A local file error was classified as IO because the syscall.Errno inside a *fs.PathError satisfies net.Error. Failing to write --save-fileparts or read `server --card` exited 3 with a connectivity hint. It now exits 1. A card request that got 401/403 or 5xx said to check the --agent-card reference. It now asks for credentials or points at the agent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A local file error was still classified as IO.
syscall.Errnoinside a*fs.PathErrorsatisfiesnet.Error, so a failed--save-filepartswrite or a missingserver --cardfile exited 3 with a connectivity hint. It now exits 1 with no hint.A card request that got 401/403 now hints to pass
--auth,--svc-paramor--credential-helper. A 5xx points at the agent. Other card failures keep the reference hint.Follow-up to yarolegovich's comment on #97.
Fixes #106