Skip to content

fix: report invalid --data-part JSON as a usage error #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ConnorMoss02 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: report invalid --data-part JSON as a usage error #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/cli/cli_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,6 +921,7 @@ func TestUsageErrors(t *testing.T) {
{"malformed agent-card url", []string{"card", "get", "-a", "http://exa mple.com"}},
{"missing agent-card file", []string{"card", "get", "-a", "/no/such/card.json"}},
{"missing --file-part file", []string{"send", "-a", "http://x", "--file-part", "/no/such/file.txt"}},
{"invalid --data-part json", []string{"send", "-a", "http://x", "--data-part", "{bad"}},
}

for _, tt := range tests {
Expand Down
2 changes: 1 addition & 1 deletion internal/flagparse/parts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ func buildFilePart(ref, mediaType string) (*a2a.Part, error) {
func buildDataPart(ref, mediaType string) (*a2a.Part, error) {
var data any
if err := json.Unmarshal(RawOrInline(ref), &data); err != nil {
return nil, fmt.Errorf("--data-part %q is not a readable file or valid JSON: %w", ref, err)
return nil, clierr.Usage(fmt.Sprintf("--data-part %q is not a readable file or valid JSON: %v", ref, err))
}
p := a2a.NewDataPart(data)
if mediaType != "" {
Expand Down
Loading