Skip to content

test: read the full event stream before asserting in the resubscription test #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mykytanetipa merged 3 commits into from
Oct 31, 2026
+0 −4
Merged

test: read the full event stream before asserting in the resubscription test #1406

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2bd5fe
test: read the full event stream before asserting in the resubscripti…
BHAWESHBHASKAR Oct 30, 2026
303aa4e
test: drop the inaccurate comment in the resubscription test
BHAWESHBHASKAR Oct 31, 2026
c55acbb
Merge branch 'main' into test/resubscription-read-full-stream
mykytanetipa Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/server/test_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,10 +682,6 @@ async def stream_generator():
# A more robust check would be to parse each SSE event
if b'data:' in chunk: # Naive check for SSE data lines
event_count += 1
if (
event_count >= 1 and len(content) > 20
): # Ensure we've processed at least one event
break

# Check content has event data (e.g., part of the first event)
assert b'artifact-0' in content # Check for the actual JSON payload
Expand Down
Loading