Skip to content

fix: respect GGML_METAL=OFF on macOS #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
provoke210 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix: respect GGML_METAL=OFF on macOS #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- fix: respect GGML_METAL=OFF on macOS by @provoke210 in #2370
- feat: update llama.cpp to ggml-org/llama.cpp@v0.4.0

## [0.3.35]
Expand Down
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ if (LLAMA_BUILD)
set(GGML_F16C "OFF" CACHE BOOL "ggml: enable F16C" FORCE)
endif()

# Metal settings (enable for both architectures)
set(GGML_METAL "ON" CACHE BOOL "ggml: enable Metal" FORCE)
# Enable Metal by default for both architectures, respecting user settings.
set(GGML_METAL "ON" CACHE BOOL "ggml: enable Metal")
set(GGML_METAL_EMBED_LIBRARY "ON" CACHE BOOL "ggml: embed metal library" FORCE)
endif()

Expand Down