Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Package setup and migration README.md |
The README describes the package, Python requirement, installation extras, import paths, and migration guidance from 3.x. |
Client examples and configuration README.md |
The README adds realtime, HTTP, and token-request examples. It documents configuration options, delta compression, LiveObjects, and the available client modes. |
Platform scope and reference links README.md |
The README lists known limitations and supported HTTP features. It updates further-reading, contribution, support, and license information. |
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related issues
- ably/ably-pubsub-python#736: The README updates the Python version floor and documents the
vcdiffextra, addressing the issue’s README-related finding.
Suggested reviewers: ttypic, owenpearson
Merge Risk: 
Minimal · previous review 2590b
-
The README update is mergeable with normal checks. Documenting 4.0 before its release-version bump does not establish an installation problem.
Pre-merge checks: 
4
-
Full details: Title check
-
Explanation
The title "Update README for 4.0" names the main change: the README is rewritten for the 4.0 ably-pubsub-server SDK. It is short, specific, and matches the raw summary and PR objectives. It does not describe every detail, which is expected for a title.
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the README page,
Then hops through examples, line by line.
It finds the channels, sets a counter,
And nibbles on the setup guide.
“Good docs,” it says, and bounds away.
Summary
Rewrites README.md for the 4.0 release of the SDK (
ably-pubsub-server), in the same structure as the Java, Go and .NET 2.0 READMEs.What changed
ably-pubsub-serverand its entry points (create_realtime_client,create_http_client).requires-pythonand the CI matrix.pip install ably-pubsub-server, and thecryptoandvcdiffextras.endpoint(replacing the removedenvironment,rest_hostandrealtime_host), logging through theably.pubsublogger (replacing the removedlog_level), and delta compression.channel.object.history()on realtime presence, token revocation, push notification target.Kept from the old README
Removed and why
[!NOTE]alert, which rendered without its text.How it was checked
log_level,environment,rest_host,realtime_host,recover) raiseTypeError, as the README says.Notes
Follow-ups
AblyRealtimeorAblyRestraisesTypeError, but the 3.x names are no longer importable fromably, sofrom ably import AblyRealtimeraisesImportError.pip install ably[vcdiff]; it should sayably-pubsub-server[vcdiff].ably-pubsub-serveragent (the Ably-Agent header isably-pubsub-python/<version> python/<version>), unlike the PHP, Java and .NET server packages. So the 40167 server-token caveat those READMEs carry is not in this README.Reference