Skip to content

fix: add User-Agent value for data collection HTTP requests #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tdruez merged 1 commit into from
Aug 28, 2026
Merged

fix: add User-Agent value for data collection HTTP requests #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions component_catalog/tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2473,6 +2473,21 @@ def test_collect_package_data(self, mock_get):
}
self.assertEqual(expected_data, collect_package_data(download_url))

@mock.patch("requests.get")
def test_collect_package_data_user_agent(self, mock_get):
mock_get.return_value = mock.Mock(
content=b"\x00",
headers={"content-length": 1},
status_code=200,
url="http://domain.com/a.zip",
)

collect_package_data("http://domain.com/a.zip")
self.assertEqual(
download.USER_AGENT,
mock_get.call_args.kwargs["headers"]["User-Agent"],
)

def test_package_create_save_set_usage_policy_from_license(self):
from policy.models import AssociatedPolicy
from policy.models import UsagePolicy
Expand Down
7 changes: 6 additions & 1 deletion dejacode_toolkit/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,19 @@
CONTENT_MAX_LENGTH = 536870912 # 512 MB
DEFAULT_TIMEOUT = 5

# Some sites (e.g. crates.io) reject requests without an identifying User-Agent.
USER_AGENT = "DejaCode (https://github.com/aboutcode-org/dejacode)"


class DataCollectionException(Exception):
pass


def collect_package_data(url):
headers = {"User-Agent": USER_AGENT}

try:
response = requests.get(url, timeout=DEFAULT_TIMEOUT, stream=True)
response = requests.get(url, headers=headers, timeout=DEFAULT_TIMEOUT, stream=True)
Comment thread
tdruez marked this conversation as resolved.
Dismissed
except (TimeoutError, requests.RequestException) as e:
raise DataCollectionException(e)

Expand Down
Loading