Skip to content

Speed up get_tokens: use findall on capture-free regex #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boidolr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Speed up get_tokens: use findall on capture-free regex #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/license_expression/_pyahocorasick.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,11 +632,11 @@ def overlap(self, other):
# tokenize to separate text from parens
_tokenizer = re.compile(
r"""
(?P<text>[^\s\(\)]+)
(?:[^\s\(\)]+) # text
|
(?P<space>\s+)
(?:\s+) # space
|
(?P<parens>[\(\)])
(?:[\(\)]) # parens
""",
re.VERBOSE | re.MULTILINE | re.UNICODE,
)
Expand All @@ -646,4 +646,4 @@ def get_tokens(tokens_string):
"""
Return an iterable of strings splitting on spaces and parens.
"""
return [match for match in _tokenizer.split(tokens_string.lower()) if match]
return _tokenizer.findall(tokens_string.lower())