Repository navigation
Cap pluggy below 1.7.0 #5363 - #5364
Merged
AyanSinhaMahapatra merged 1 commit intoOct 16, 2026
Merged
Conversation
pluggy 1.7.0 rejects the class-based hookspecs that plugincode registers, so importing scancode.cli fails with "did not find any 'pre_scan' hooks". Keep pluggy below 1.7.0 until plugincode is updated. Signed-off-by: 72004 <syahra2014@gmail.com>
AyanSinhaMahapatra
approved these changes
Oct 16, 2026
AyanSinhaMahapatra
left a comment
Member
There was a problem hiding this comment.
Thanks! This is okay as a temporary fix to our tests, but pip install scancode-toolkit will continue to be broken (and we might need to modify some code to support newer version of pluggy potentially too), and so I'm not closing the issue.
AyanSinhaMahapatra
merged commit Oct 16, 2026
dccaa76
into
aboutcode-org:develop
35 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference:
pluggy 1.7.0 stopped accepting the class-based hookspecs that
plugincoderegisters (PreScanPlugin,ScanPlugin, etc.), soscancodenow fails on import with:requirements.txtalready pinspluggy==1.6.0, but the published wheels only declarepluggy >= 1.0.0, which means a freshpip install scancode-toolkitpicks up 1.7.0 and breaks. This PR caps it at< 1.7.0inpyproject.toml,pyproject-scancode-toolkit.tomlandpyproject-scancode-toolkit-mini.toml, and adds a CHANGELOG entry.On the pluggy side (pytest-dev/pluggy#794), the maintainers said class hookspecs were never meant to be supported, so a longer-term fix probably has to happen in
plugincode. This just gets installs working again in the meantime.Checked in a clean venv:
pluggy==1.7.0+plugincode:import plugincode.pre_scanraises the error abovepluggy>=1.0.0,<1.7.0(resolves to 1.6.0): all fiveplugincodestage modules import fine