Repository navigation
Use standard apk PURL type for Alpine packages - #5366
Open
Vaibhav200303 wants to merge 2 commits into
Open
Vaibhav200303 wants to merge 2 commits into
Vaibhav200303 wants to merge 2 commits into
Conversation
Signed-off-by: Vaibhav Sharma <vs9109807@gmail.com>
Signed-off-by: Vaibhav Sharma <vs9109807@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4964
Alpine package handlers now emit the standard
apkPackage URL type. This also updates PURLs for Alpine dependencies and source packages and refreshes the Alpine expected fixtures.The Alpine installed-package tests exposed a separate Windows path bug: package assembly used
pathlib.Pathto join ScanCode resource paths. On Windows this inserted backslashes, so no extracted files matched their package file references. The join now usesposixpath, matching ScanCode's resource path format on every platform.Validation:
develop,venv\Scripts\python.exe -m pytest tests/packagedcode/test_alpine.py -q --disable-warnings --tb=line: 116 passed, 3 failed on Windows.git diff --checkpasses.Signed-off-by: Vaibhav Sharma vs9109807@gmail.com