carry field normalization into parsed year in ParseYearAnd#2109
Closed
nabhan06 wants to merge 1 commit into
Closed
carry field normalization into parsed year in ParseYearAnd#2109nabhan06 wants to merge 1 commit into
nabhan06 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropped year carry in ParseCivilTime
ParseYearAndparses the year on its own and normalizes it into the ~2400 range before handing the rest of the string toParseTime, then rebuilds the result from the original year plus the normalized month..second fields taken fromcs. When one of those fields carries across the year boundary (a:60leap second at23:59:60on Dec 31, or an end-of-year rollover), that carry lives incs.year()and was dropped, soParseCivilTime("2020-12-31T23:59:60")produced2020-01-01T00:00:00while constructingCivilSecond(2020, 12, 31, 23, 59, 60)directly gives2021-01-01T00:00:00. This reapplies the same carry to the original year, which is a no-op whenever no rollover happened.