Repository navigation
Conversation
scripts/tag.js used the deprecated ::set-output workflow command. Once GitHub disables it, steps.tag.outputs.tag is empty and a pre-release would be published as latest. Port the fix from accordproject/concerto#1324 and accordproject/concerto-codegen#297. Signed-off-by: Ujjwal Verma <ujjwalverma010305@gmail.com>
3 of 8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to accordproject/concerto-codegen#288
scripts/tag.jspicks the npm dist-tag for a release (latest, orunstablefor a pre-release) and hands it topublish.ymlwith the::set-outputworkflow command, which GitHub has deprecated: every release logs "Theset-outputcommand is deprecated and will be disabled soon". Once it is disabled,steps.tag.outputs.tagis empty,npm publishfalls back to npm's default tag, and a pre-release would be published aslatest.This ports the fix already merged in accordproject/concerto#1324 and accordproject/concerto-codegen#297.
Changes
scripts/tag.jsappendstag=--tag=<tag>to the file named byGITHUB_OUTPUT, sosteps.tag.outputs.taginpublish.ymlgets the same value as before.GITHUB_OUTPUT), it prints--tag=<tag>, for running it by hand.Flags
publish.ymlis unchanged and reads the same output.Screenshots or Video
N/A
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:fix/tag-github-outputTesting: with
GITHUB_OUTPUTset,node scripts/tag.js 2.0.0writestag=--tag=latestand2.1.0-beta.1writestag=--tag=unstable; without it, the script prints--tag=latest/--tag=unstable; an invalid version still exits with code 1.