Skip to content

support for 3d+1 - #110

Closed
rakovpublic wants to merge 0 commit into
acgetchell:mainfrom
rakovpublic:develop
Closed

support for 3d+1#110
rakovpublic wants to merge 0 commit into
acgetchell:mainfrom
rakovpublic:develop

Conversation

@rakovpublic

Copy link
Copy Markdown

support for 3d+1

@rakovpublic
rakovpublic requested a review from acgetchell as a code owner July 20, 2026 04:08
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 127 files, which is 27 over the limit of 100.

To get a review, narrow the scope:
• coderabbit review --type committed # exclude uncommitted changes
• coderabbit review --dir # limit to a subdirectory
• coderabbit review --base # compare against a closer base

Upgrade to a paid plan to raise the limit.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 845fbeb1-8687-4e9d-9b9c-6a409d0ac1f5

📥 Commits

Reviewing files that changed from the base of the PR and between c37fa09 and 1941643.

📒 Files selected for processing (127)
  • .appveyor.yml
  • .clang-format
  • .clang-tidy
  • .cmake-format.yaml
  • .codecov.yml
  • .coderabbit.yaml
  • .github/CONTRIBUTING.md
  • .github/ISSUE_TEMPLATE/bug_report.md
  • .github/ISSUE_TEMPLATE/feature_request.md
  • .github/dependabot.yml
  • .github/workflows/asan.yml
  • .github/workflows/clang-format-check.yml
  • .github/workflows/codecov-upload.yml
  • .github/workflows/codeql.yml
  • .github/workflows/cpp-linter.yml
  • .github/workflows/cppcheck.yml
  • .github/workflows/doxygen.yml
  • .github/workflows/linux-clang.yml
  • .github/workflows/linux-gcc.yml
  • .github/workflows/lsan.yml
  • .github/workflows/macos.yml
  • .github/workflows/msan.yml
  • .github/workflows/sonarcloud.yml
  • .github/workflows/tsan.yml
  • .github/workflows/valgrind.yml
  • .github/workflows/whitespace.yml
  • .github/workflows/windows-msvc.yml
  • .github/workflows/windows-pkgx.yml
  • .gitignore
  • .gitpod.yml
  • .travis.yml
  • CMakeLists.txt
  • CMakePresets.json
  • Dockerfile
  • LICENSE.md
  • README.md
  • cmake/Cache.cmake
  • cmake/Sanitizers.cmake
  • cmake/StandardProjectSettings.cmake
  • cmake/StaticAnalyzers.cmake
  • docs/4d-standard-cdt-candidate.md
  • include/Apply_move.hpp
  • include/Detailed_balance_4.hpp
  • include/Ergodic_moves_3.hpp
  • include/Ergodic_moves_4.hpp
  • include/Foliated_triangulation.hpp
  • include/Foliated_triangulation.hpp.before-4d-compat-fix
  • include/Foliated_triangulation.hpp.before-swap-fix
  • include/Foliated_triangulation_4.hpp
  • include/Formatters.hpp
  • include/Geometry.hpp
  • include/Manifold.hpp
  • include/Manifold.hpp.before-4d-compat-fix
  • include/Metropolis.hpp
  • include/Metropolis_4.hpp
  • include/Move_always.hpp
  • include/Move_catalog_4.hpp
  • include/Move_command.hpp
  • include/Move_strategy.hpp
  • include/Move_tracker.hpp
  • include/Observables_4.hpp
  • include/Periodic_3_triangulations.hpp
  • include/Phase_analysis.hpp
  • include/S4Action.hpp
  • include/Settings.hpp
  • include/Simulation_output.hpp
  • include/Torus_d.hpp
  • include/Triangulation_traits.hpp
  • include/Utilities.hpp
  • instructions.txt
  • scripts/asan.sh
  • scripts/build.bat
  • scripts/build.sh
  • scripts/clang-tidy.sh
  • scripts/codecov.sh
  • scripts/cppcheck.sh
  • scripts/debug.sh
  • scripts/fast-build.bat
  • scripts/fast-build.sh
  • scripts/gcov.sh
  • scripts/iwyu.sh
  • scripts/lsan.sh
  • scripts/msan.sh
  • scripts/pvs-studio.sh
  • scripts/run-cds-phase-scan.ps1
  • scripts/run-cds-phase-scan.sh
  • scripts/scan.sh
  • scripts/slurm.sh
  • scripts/tsan.sh
  • sonar-project.properties
  • src/CMakeLists.txt
  • src/bistellar-flip.cpp
  • src/cdt-opt.cpp
  • src/cdt.cpp
  • src/initialize.cpp
  • src/optimize-initialize.py
  • src/test.py
  • testoutput.txt
  • tests/Apply_move_test.cpp
  • tests/Bistellar_flip_test.cpp
  • tests/CMakeLists.txt
  • tests/Checkpoint_4_test.cpp
  • tests/Detailed_balance_test.cpp
  • tests/Ergodic_moves_3_test.cpp
  • tests/Ergodic_moves_4_test.cpp
  • tests/Foliated_triangulation_4_test.cpp
  • tests/Foliated_triangulation_test.cpp
  • tests/Function_ref_test.cpp
  • tests/Geometry_4_test.cpp
  • tests/Geometry_test.cpp
  • tests/Manifold_4_test.cpp
  • tests/Manifold_test.cpp
  • tests/Metropolis_4_test.cpp
  • tests/Metropolis_test.cpp
  • tests/Move_always_test.cpp
  • tests/Move_command_test.cpp
  • tests/Move_tracker_test.cpp
  • tests/Observables_4_test.cpp
  • tests/Phase_analysis_test.cpp
  • tests/S4Action_test.cpp
  • tests/Settings_test.cpp
  • tests/Tetrahedron_test.cpp
  • tests/Time_reversal_4_test.cpp
  • tests/Torus_test.cpp
  • tests/Utilities_test.cpp
  • tests/Vertex_test.cpp
  • vcpkg.json

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Review on demand using usage pricing
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rakovpublic
rakovpublic marked this pull request as draft July 27, 2026 21:16
@acgetchell

acgetchell commented Jul 27, 2026

Copy link
Copy Markdown
Owner

I'll have v1.0.0rc-3 out soon, please rebase on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants