Create content-present-reflow-sc9kkf - #2445
WilcoFiers wants to merge 3 commits into
Conversation
Split from #2429. Original work by Helen Burge. Co-authored-by: HelenBurge <41951878+HelenBurge@users.noreply.github.com>
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WilcoFiers
left a comment
There was a problem hiding this comment.
I stopped after the expectation. Plenty to do already. I can't request changes since this is my own PR.
|
|
||
| ## Applicability | ||
|
|
||
| This rule applies to any non-excepted element containing visible content or functional components, requiring text to reflow when the viewport is set to a width of 320 CSS pixels for horizontal languages or a height of 256 CSS pixels for vertical languages; to align applicability more closely with these reflow requirements, it can be refined to target only visible content with a height of at least 320 CSS pixels on pages with vertical scrolling, or a height of at least 256 CSS pixels on pages with horizontal scrolling. |
There was a problem hiding this comment.
- "non-excepted" What does that mean?
- did you mean (visible content) or (functional components) or visible (content or functional components)?
- "requiring text to reflow" How do I know if the text requires reflow? I would probably pull this and say regardless of if it requires reflow, if content disappears on.a 320x256 viewport that's a failure.
- "320 CSS pixels for horizontal languages" WCAG doesn't say this only applies to horizontal writing systems. Why would we limit it that way? Horizontal text can easily end up being clipped vertically when the width of the viewport changes.
- "to align applicability more closely with these reflow requirements..." I don't understand what this means or what its doing here.
- Does this include decorative content? For images, are you sure ANY truncation should result in a failure?
- Is it acceptable to replace larger things with smaller ones? Like a text "home" with a home icon for instance?
- You're not accounting for text that was clipped/hidden in the original view. Presumably content that's cut off in any resolution shouldn't fail this requirement.
- I think we need to specify the original viewport. If I start at 321x257 and then go to 320x256 that isn't likely to make much of a difference. I don't think people can test this consistently if we don't establish the starting resolution.
There was a problem hiding this comment.
I am going to rewrite this in my own words soon... maybe...
There was a problem hiding this comment.
Start with 1280 x 1024 resolution going down to 320 to 256
There was a problem hiding this comment.
There was a problem hiding this comment.
Example - non-wrapping code - Wilco wants a pass - if the code must maintain a line then do not wrap it.
Procedure for code snippets
Display the web page in a user agent where the page can be zoomed, or the user agent can be resized.
Zoom in or resize the browser window so that the viewport is equivalent to 320 CSS pixels wide.
The code snippets fits within the width so that it is only necessary so scroll vertically to read each line of code.
Or, for code where non-wrapping lines are not essential, the code wraps or a mechanism is provided to allow line wrapping.
Or, the indentation and linebreaks are meaningful to the code language.
There was a problem hiding this comment.
Explain in background that the tester knows the language requirements
There was a problem hiding this comment.
Clarify the reflow tests specifically
Text is not cutoff at 320 CSS pixels
Orientation scrolls do not exist at 320 CSS pixels without a content exception
Content is not missing at 320 CSS pixels - this is this one
| Each target element: | ||
|
|
||
| Retains all content and functionality when viewed with a height of at least 320 CSS pixels on pages with vertical scrolling, or a height of at least 256 CSS pixels on pages with horizontal scrolling: |
There was a problem hiding this comment.
This doesn't exactly follow how to write an ACT rule. I'd do something like this:
| Each target element: | |
| Retains all content and functionality when viewed with a height of at least 320 CSS pixels on pages with vertical scrolling, or a height of at least 256 CSS pixels on pages with horizontal scrolling: | |
| For each target element, when the viewport is set to 320 by 256 CSS pixels, the content is not cut off, removed, or obscured by another element, except if one of the following is true: | |
| - the hidden content can be scrolled into view, or | |
| - an [instrument][] is available to reveal the content. |
I think you're throwing far too much at the wall here hoping to find issues.
- First you say things can't be cut off, and then you follow it up by saying it can if you can scroll it into view.
- "unavailable as a result of viewport constraints, zoom, or responsive behaviour;" what are these things, and how do I test them? I know at least 3 different zoom methods, which ones do you mean? I think this can be cut.
| Each target element: | ||
|
|
||
| Retains all content and functionality when viewed with a height of at least 320 CSS pixels on pages with vertical scrolling, or a height of at least 256 CSS pixels on pages with horizontal scrolling: | ||
| - Does not cut-off, remove, or make content unavailable as a result of viewport constraints, zoom, or responsive behaviour; and |
There was a problem hiding this comment.
Is truncation allowed at all? Like with the three dots.
There was a problem hiding this comment.
Yes - that is ok if the content is still available in a form - like the subsequent page
| @@ -0,0 +1,257 @@ | |||
| --- | |||
There was a problem hiding this comment.
This should be a .md file. File extension is missing.
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
First draft of the content-present-reflow rule: content is not missing at 320 CSS pixels.
Split from #2429 so each reflow rule can be reviewed independently. Original work by @HelenBurge.
Related to #2424.
Need for Call for Review:
This will require a 2 weeks Call for Review
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve
Made with Cursor