Repository navigation
Conversation
Ransack 6 raises when a model does not define ransackable_associations, so every spec failed once bundler resolved ransack 6.1.0. Co-Authored-By: Clanker
RubyGems sorts 4.0.0.beta23 below 4.0, so "< 4.0" let bundler pick an ActiveAdmin 4 beta, which this jQuery plugin does not support. Co-Authored-By: Clanker
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the ActiveAdmin dependency cap and Ransack compatibility updates.
No open issues 🎉
What changed in this PR
Tightens the gem’s ActiveAdmin dependency for the planned 1.3.0 release and updates the test app for Ransack 6 compatibility.
Changes:
- Changes the ActiveAdmin upper bound from
< 4.0to< 4.0.0.ato exclude ActiveAdmin 4 prereleases. - Adds an empty
ransackable_associationsallowlist to the dummyAuthormodel.
| File | Description |
|---|---|
spec/support/rails_template.rb |
Defines the association allowlist required by Ransack 6. |
active_admin_filters_visibility.gemspec |
Tightens the dependency cap to keep resolution on ActiveAdmin 3. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caps the
activeadmindependency at< 4.0.0.aso bundler can no longer resolve an ActiveAdmin 4 prerelease. This is the gemspec 1.3.0 will ship for ActiveAdmin 3 from current master.RubyGems sorts
4.0.0.beta23below4.0, so the old< 4.0admitted every ActiveAdmin 4 beta, and this jQuery plugin does not work there..ais the lowest possible 4.0.0 prerelease, so the cap excludes all of them.The suite was red on a fresh bundle: Ransack 6 raises when a model leaves
ransackable_associationsundefined. The dummy app template now defines it as[]forAuthor.Release impact: none on its own. This becomes part of 1.3.0, a minor release. ActiveAdmin 4 support will ship separately as 2.0.0.
Verified:
bundle exec rspec spec/filters_visibility_spec.rbpasses (5 examples) on Ruby 3.4, Rails 8.1.4.1, ActiveAdmin 3.5.2, Ransack 6.1.0.