Skip to content

Exclude ActiveAdmin 4 prereleases from the dependency - #7

Open
senid231 wants to merge 2 commits into
masterfrom
activeadmin-v3-bound
Open

senid231 wants to merge 2 commits into
masterfrom
activeadmin-v3-bound

Conversation

@senid231

Copy link
Copy Markdown
Member

Caps the activeadmin dependency at < 4.0.0.a so bundler can no longer resolve an ActiveAdmin 4 prerelease. This is the gemspec 1.3.0 will ship for ActiveAdmin 3 from current master.

RubyGems sorts 4.0.0.beta23 below 4.0, so the old < 4.0 admitted every ActiveAdmin 4 beta, and this jQuery plugin does not work there. .a is the lowest possible 4.0.0 prerelease, so the cap excludes all of them.

The suite was red on a fresh bundle: Ransack 6 raises when a model leaves ransackable_associations undefined. The dummy app template now defines it as [] for Author.

Release impact: none on its own. This becomes part of 1.3.0, a minor release. ActiveAdmin 4 support will ship separately as 2.0.0.

Verified: bundle exec rspec spec/filters_visibility_spec.rb passes (5 examples) on Ruby 3.4, Rails 8.1.4.1, ActiveAdmin 3.5.2, Ransack 6.1.0.

Ransack 6 raises when a model does not define ransackable_associations,
so every spec failed once bundler resolved ransack 6.1.0.

Co-Authored-By: Clanker
RubyGems sorts 4.0.0.beta23 below 4.0, so "< 4.0" let bundler pick an
ActiveAdmin 4 beta, which this jQuery plugin does not support.

Co-Authored-By: Clanker

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the ActiveAdmin dependency cap and Ransack compatibility updates.

No open issues 🎉

What changed in this PR

Tightens the gem’s ActiveAdmin dependency for the planned 1.3.0 release and updates the test app for Ransack 6 compatibility.

Changes:

  • Changes the ActiveAdmin upper bound from < 4.0 to < 4.0.0.a to exclude ActiveAdmin 4 prereleases.
  • Adds an empty ransackable_associations allowlist to the dummy Author model.
File Description
spec/​support/​rails_template.rb Defines the association allowlist required by Ransack 6.
active_admin_filters_visibility.gemspec Tightens the dependency cap to keep resolution on ActiveAdmin 3.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants