Repository navigation
Theme the companion datetimepicker via --aa-datetimepicker-* bridge vars - #65
Merged
Merged
Conversation
Feed active_admin_datetimepicker's --aa-datetimepicker-* inputs from the theme palette on :root, so when both plugins are used the xdsoft picker is themed in light and dark with no per-app overrides. The bridge points at the --aa-* vars (redefined per mode), so one set covers both; it is an inert no-op when the datetimepicker plugin is absent.
Merged
senid231
pushed a commit
to senid231/active_admin_theme
that referenced
this pull request
Nov 4, 2026
Minor, not major: the variable contract only grows - $skinTitleBarHeight joins it - and nothing that worked against 3.1.1 stops working. Several defaults do look different, and the Upgrading section now spells them out. What moved since 3.1.1: activeadmin-plugins#74 a title-bar dropdown opens under its own button again activeadmin-plugins#73 button_to action items stay on the title bar's row activeadmin-plugins#72 a wigu/all umbrella require; title-bar dropdowns right-align activeadmin-plugins#71 the header, title bar and flash bar are pinned to the viewport and index-table headers stick, with per-table opt-outs activeadmin-plugins#70 date-range filters laid out with flexbox activeadmin-plugins#69 documentation for crisscross highlighting and the Trix editor activeadmin-plugins#68 crisscross cell highlighting for index tables activeadmin-plugins#67 Trix / ActionText editor themed in light and dark activeadmin-plugins#65 --aa-datetimepicker-* bridge variables activeadmin-plugins#64 utility nav with the server clock, theme switch and glyph logout activeadmin-plugins#63 dark-mode interactive states activeadmin-plugins#62 dark styling for select2 and tom-select The npm package moves with it: src/ is regenerated from app/assets by the prepare script, so the Sprockets and bundler consumers ship the same files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feed the companion active_admin_datetimepicker's
--aa-datetimepicker-*inputs from this theme's--aa-*palette on:root.When both plugins are used, the xdsoft date-time picker is themed automatically — accent, surfaces, text, border and hover — in both light and dark mode, with no per-app overrides. The bridge vars point at the
--aa-*custom properties, which are themselves redefined per mode (dark palette), so a single set on:rootcovers both.active_admin_datetimepickerisn't installed (nothing reads the vars; 7 harmless custom properties).--aa-datetimepicker-*downstream.Lets consumers drop the
:root { --aa-datetimepicker-*: var(--aa-*) }block and the local.xdsoft_*/ dark-mode overrides they used to carry.