LED feedback for safe mode and BLE discovery mode on boot-button boards - #11232
Open
dhalbert wants to merge 1 commit into
Open
LED feedback for safe mode and BLE discovery mode on boot-button boards#11232dhalbert wants to merge 1 commit into
dhalbert wants to merge 1 commit into
Conversation
Now pressing the boot button for safe mode or BLE discovery mode will display a solid yellow or blue for enough time to give feedback to the user. Also, the two button-press intervals ran back to back and both polled the button by level, so a click during the yellow flash was still held down when the discovery interval started -- it entered discovery mode and erased bonding unasked. The discovery interval now requires a release before a press counts. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On boards using the BOOT button to enter safe mode or BLE discovery, there was no LED feedback that the user's BOOT button press was successful.
Tested on a Metro ESP32-S3. Also built for feather_nrf52840_express and tested for any regression with double-click reset mode changes.
Claude wrote the code. I tested and found the overlap problem, and had it fix that. I rewrote the comments and the text here for clarity.