Repository navigation
Add native Ethernet mii support
#11511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tannewt
wants to merge
7
commits into
adafruit:main
Choose a base branch
from
tannewt:ethernet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,701
−395
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
71c9748
Add native Ethernet over `mii` support
tannewt 20e4b39
Remove 7002dk because flash is too small
tannewt 1807b09
Fix espressif for IDF 6.1
tannewt 162d19d
Fix pre-commit
tannewt 2ebe6d7
Only enable MII on SoCs with support for EMAC
tannewt a98e51a
Merge remote-tracking branch 'adafruit/main' into ethernet
tannewt e58f004
Merge remote-tracking branch 'adafruit/main' into ethernet
tannewt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| { "base_branch": "adafruit/main" } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 23 additions & 1 deletion
24
ports/espressif/boards/espressif_esp32p4_function_ev/board.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,31 @@ | ||
| // This file is part of the CircuitPython project: https://circuitpython.org | ||
| // | ||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Scott Shawcroft for Adafruit Industries | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 Scott Shawcroft for Adafruit Industries | ||
| // | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| #include "supervisor/board.h" | ||
|
|
||
| #if CIRCUITPY_MII | ||
| #include "common-hal/mii/__init__.h" | ||
| #include "shared-bindings/mii/Ethernet.h" | ||
| #include "shared-bindings/mii/RMII.h" | ||
| #include "shared-bindings/microcontroller/Pin.h" | ||
|
|
||
| // The board owns its ethernet instance and the RMII bus wiring. | ||
| mii_rmii_obj_t board_rmii_obj; | ||
| mii_ethernet_obj_t board_ethernet_obj; | ||
|
|
||
| void board_init(void) { | ||
| common_hal_mii_rmii_construct(&board_rmii_obj, | ||
| &pin_GPIO31, &pin_GPIO52, // MDC, MDIO | ||
| &pin_GPIO29, &pin_GPIO30, &pin_GPIO28, // RXD0, RXD1, RX_DV | ||
| &pin_GPIO34, &pin_GPIO35, &pin_GPIO49, // TXD0, TXD1, TX_EN | ||
| &pin_GPIO50, // REFCLK | ||
| &pin_GPIO51); // PHY reset (active low) | ||
| common_hal_mii_ethernet_construct(&board_ethernet_obj, &board_rmii_obj, 1); | ||
| mii_set_default_instance(&board_ethernet_obj); | ||
| } | ||
| #endif | ||
|
|
||
| // Use the MP_WEAK supervisor/shared/board.c versions of routines not defined here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| CONFIG_ESP32P4_SELECTS_REV_LESS_V3=y | ||
| CONFIG_ESP32P4_REV_MIN_100=y | ||
| CONFIG_ETH_USE_ESP32_EMAC=y |
28 changes: 22 additions & 6 deletions
28
ports/espressif/boards/espressif_esp32p4x_function_ev/board.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,25 @@ | ||
| // This file is part of the CircuitPython project: https://circuitpython.org | ||
| // | ||
| // SPDX-FileCopyrightText: Copyright (c) 2020 Scott Shawcroft for Adafruit Industries | ||
| // | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| #include "supervisor/board.h" | ||
|
|
||
| #if CIRCUITPY_MII | ||
| #include "common-hal/mii/__init__.h" | ||
| #include "shared-bindings/mii/Ethernet.h" | ||
| #include "shared-bindings/mii/RMII.h" | ||
| #include "shared-bindings/microcontroller/Pin.h" | ||
|
|
||
| // The board owns its ethernet instance and the RMII bus wiring. | ||
| mii_rmii_obj_t board_rmii_obj; | ||
| mii_ethernet_obj_t board_ethernet_obj; | ||
|
|
||
| void board_init(void) { | ||
| common_hal_mii_rmii_construct(&board_rmii_obj, | ||
| &pin_GPIO31, &pin_GPIO52, // MDC, MDIO | ||
| &pin_GPIO29, &pin_GPIO30, &pin_GPIO28, // RXD0, RXD1, RX_DV | ||
| &pin_GPIO34, &pin_GPIO35, &pin_GPIO49, // TXD0, TXD1, TX_EN | ||
| &pin_GPIO50, // REFCLK | ||
| &pin_GPIO51); // PHY reset (active low) | ||
| common_hal_mii_ethernet_construct(&board_ethernet_obj, &board_rmii_obj, 1); | ||
| mii_set_default_instance(&board_ethernet_obj); | ||
| } | ||
| #endif | ||
|
|
||
| // Use the MP_WEAK supervisor/shared/board.c versions of routines not defined here. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lines 1-6 header seems to have been deleted inadvertently.