Repository navigation
zephyr-cp: enable adafruit_pixelbuf and _pixelmap on boards with neopixel_write - #11538
Merged
Merged
Conversation
Boards with neopixel_write now also get adafruit_pixelbuf and _pixelmap. Regenerated autogen_board_info.toml for the six affected nRF boards; the regeneration also picks up pending usb_host_bulk and watchdog changes from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Both args had kind 0, which mp_arg_parse_all() asserts against. Ports built with NDEBUG skipped the assert; zephyr-cp keeps asserts on, so every PixelMap() call hung the board. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change by Claude, directed by @dhalbert.
adafruit_pixelbufand_pixelmapon zephyr-cp boards that haveneopixel_write. For now that's the nRF boards withCONFIG_PWM_NRFX. This is done by addingneopixel_writetoREVERSE_DEPENDENCIESincptools/build_circuitpython.py.autogen_board_info.tomlfor the six affected boards.Bug found and fixed in passing
_pixelmap.PixelMap()constructor args, which had noMP_ARG_OBJkind and tripped anassert()inmp_arg_parse_all(). Ports built withNDEBUGdidn't notice, but on zephyr-cp everyPixelMap()call hung the board.Testing
feather_nrf52840_zephyr,feather_nrf52840_sense_zephyr,clue_nrf52840_zephyr,nrf5340dk,nrf54l15dk,nrf54lm20dk.PixelBufandPixelMapon a Feather nRF52840 with the onboard NeoPixel and a 16-pixel RGBW ring on A0: even/odd maps, grouped indices, a reversed map with slice assignment, andauto_write=Falsewithshow().