Repository navigation
Conversation
When the peer disconnects, the Connection object's connection pointer is set to NULL. disconnect() still passed it to common_hal_bleio_connection_disconnect(), relying on each port to do nothing when already disconnected. espressif reads conn_handle from it without checking, so the next disconnect() hard-faulted. nordic, silabs and ble_hci don't check either. Call common-hal only when the connection is still connected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diagnosis and code by Claude, reviewed by @dhalbert.
Problem
Connection.disconnect()after the peer had already disconnected caused a hard fault.Connectionobject's internalconnectionpointer is set toNULL.disconnect()still passed that pointer tocommon_hal_bleio_connection_disconnect(), relying on each port to do nothing when already disconnected.conn_handlethrough it without checking, and faults on theNULLread.ble_hcidon't check either. zephyr-cp does.Fix
disconnect()now calls common-hal only ifcommon_hal_bleio_connection_get_connected()is true. Every port'sget_connected()already handles aNULLconnection.Testing
Metro ESP32-S3 as central, nRF54LM20 DK as peripheral. The DK disconnects, then the Metro calls
disconnect()twice:maindisconnect()