Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/csv-generate/lib/stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ const generate = (opts) => {
chunk = Buffer.from(chunk);
controller.enqueue(chunk);
},
function () {
controller.close();
function (err) {
if (err) {
controller.error(err);
} else {
controller.close();
}
},
);
},
Expand Down
28 changes: 28 additions & 0 deletions packages/csv-generate/test/api.web_stream.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,36 @@
import "should";
import assert from "node:assert/strict";
import { generate as generateStream } from "../lib/stream.js";
import { generate as generateClassic } from "../lib/index.js";

describe("api stream", function () {
it("rejects invalid column values", async function () {
const reader = generateStream({
length: 1,
columns: [() => ({})],
}).getReader();
const error = {
message:
"INVALID_VALUE: values returned by column function must be a string, a number or null, got {}",
};
await Promise.all([
assert.rejects(reader.read(), error),
assert.rejects(reader.closed, error),
]);
});

it("closes after generating valid values", async function () {
const reader = generateStream({
length: 1,
columns: [() => "a", () => null, () => 1],
}).getReader();
const { value, done } = await reader.read();
assert.equal(done, false);
assert.equal(value.toString(), "a,,1");
assert.deepEqual(await reader.read(), { value: undefined, done: true });
await reader.closed;
});

it.skip("perf classic", async function () {
console.time("classic");
const generator = generateClassic({
Expand Down
Loading