Repository navigation
fix(csv-stringify): quote empty strings returned by casts - #521
Open
sunlishuo25 wants to merge 1 commit into
Open
sunlishuo25 wants to merge 1 commit into
sunlishuo25 wants to merge 1 commit into
Conversation
sunlishuo25
marked this pull request as ready for review
October 4, 2026 16:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a cast changes a field to an empty string,
quoted_match: /^$/andquoted_string: trueomit the quotes:Select the empty-string branch using the cast value, while keeping
quoted_stringlimited to original string fields. Tests cover callback and sync APIs, field-level options, null/undefined, non-string fields, andquoted_empty: false.The default boolean cast returns
''forfalse, sofalsenow also matchesquoted_match: /^$/. Null and undefined stay unquoted with that option.Validation on Node 24.16.0:
npm test --workspace csv-stringify -- --no-parallel: TypeScript passed, 237 tests passed, 1 existing pending test.Node 20/22 and the wider browser matrix were not run locally. Generated files are omitted, following recent source-fix PRs and the package's release build scripts.
Developed with GPT assistance.