Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csv-generatesizes object records by adding each column's.length, although column functions explicitly support strings, numbers andnull. A null column throws, and numeric or empty-string columns generate the entire finite input before emitting the first record. Withsleep, buffered records also share the end flag and can be dropped: five numeric records currently return only one.Emit one object record per read so the Readable stream controls when generation resumes. This also preserves the delay between records and finishes only after the last record is delivered. Text-mode chunk sizing is unchanged.
For example, this callback should receive five
[42]records:The regressions cover null values in the sync API, bounded generation before the first streamed record, supported value preservation, and complete delayed output. Against the original source, the three affected test files produced 7 failures and 9 passes; with the fix, all 16 pass.
Validation on Ubuntu with Node 24.19.0 and the lockfile-installed dependencies:
npm ci, including the original Husky setup.npm run buildpassed.npm testpassed for all 14 workspaces: 1,085 passing tests and 6 existing pending tests. The first full attempt hit the existing one-secondsleeptest's timing assertion; the unchanged full command passed on rerun. No assertion or test selection was relaxed.npm run lint:checkpassed with no errors and 6 existing pending-test warnings.Generated distributions are left to the existing release build process.
AI disclosure: this change and its tests were developed with OpenAI Codex and checked through the public APIs and project test suite.