Repository navigation
fix(csv-parse): honor normalized objname in result collection - #523
Merged
wdavidw merged 2 commits intoOct 9, 2026
Merged
Conversation
lux-liang
marked this pull request as ready for review
October 9, 2026 03:38
Member
|
Please limit the number of tests to the minimal. IA generates way too many tests and this become a technical debt. |
Contributor
Author
|
Reduced the added coverage from 16 cases to 3: sync |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sync collector treats
objname: 0as disabled when choosing its result container, returning an array whose string-keyed records serialize to[]. The callback collector treatsobjname: nullorfalseas enabled even though the parser normalizes them to disabled, losing record fields.Use the parser's normalized
objnamein both collectors. Keyed results retain their null prototype; disabled mode returns complete record arrays. Three added regression cases cover the sync zero index and the two disabled callback values. Existing tests cover the other keyed-record behavior.Validation on native Windows Node.js 24.19.0:
dad8ff7, with Node.js 20, 22 and 24.AI assistance was used for implementation, testing and review.