Repository navigation
fix(csv-parse): cast hex, octal and binary literals to their value - #524
Merged
Merged
Conversation
__isFloat() accepts anything Number() can convert, including 0x10, 0o17 and 0b11, but the value was then read with parseFloat(), which stops at the prefix and returns 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
cast: true, hex, octal and binary literals are silently turned into0:__isFloat()(value - parseFloat(value) + 1 >= 0) returns true for these strings because the subtraction coerces withNumber(). The value is then read withparseFloat(), which stops at thex/o/band returns0.This uses
Number(field)for the conversion so it agrees with the check. For everything__isFloat()already accepted,Number()andparseFloat()give the same result. The only exception is these prefixed literals, which now come out as[16, 15, 3]instead of0.I added a case to
test/option.cast.ts. It fails before the change, andnpm testinpackages/csv-parsepasses (616 passing).