Skip to content

fix(build): make uses the repo's pinned vp, not the global one #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adampeterhiggins merged 1 commit into from
Oct 21, 2026
Merged

fix(build): make uses the repo's pinned vp, not the global one #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,11 @@ SOURCE_FINGERPRINT = { git rev-parse HEAD; git diff HEAD; git ls-files --others
SKIP_BUILD ?= 0
# FORCE=1 lets update-next rebuild even when nothing changed since the last one.
FORCE ?= 0
# The repo's pinned vite-plus, not whatever `vp` is on PATH: an older global
# install can't parse newer task configs and fails to load the task graph.
# Deferred so a fresh checkout falls back to the global one for its first
# install, then picks up the local binary in later recipes.
VP = $(if $(wildcard node_modules/.bin/vp),./node_modules/.bin/vp,vp)

.DEFAULT_GOAL := help

Expand Down Expand Up @@ -98,7 +103,7 @@ deps: ## Run 'vp i' only if pnpm-lock.yaml changed since the last install
printf " ok dependencies up to date\n"; \
else \
echo "--> pnpm-lock.yaml changed, running vp i"; \
vp i; \
$(VP) i; \
fi

update-build-%: deps ## Build version % into release-mock (signed, mock feed, zip)
Expand All @@ -108,7 +113,7 @@ update-build-%: deps ## Build version % into release-mock (signed, mock feed, zi
exit 1; \
fi
T3CODE_DESKTOP_IDENTITY="$(IDENTITY)" \
vp run dist:desktop:artifact \
$(VP) run dist:desktop:artifact \
--platform mac --target zip --arch $(ARCH) \
--mock-updates --mock-update-server-port $(PORT) \
$(if $(filter 1,$(SKIP_BUILD)),--skip-build,) \
Expand Down