Repository navigation
test(web): ChatMarkdown tests match the fork's link icons and chip labels - #514
Merged
Merged
Conversation
adampeterhiggins
force-pushed
the
t3code/fix-chatmarkdown-fork-tests
branch
from
October 29, 2026 10:45
52873bb to
208500c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
ChatMarkdown.browser.test.tsxtests fail onmainand on the sync branch (#513). Both are upstream tests checking behaviour the fork has changed. Each sync brings them back unchanged.google.com/s2/favicons<img>for public links. feat(web,mobile): tool calls show monochrome brand marks instead of favicon squares #480 removed favicon fetching, and links now draw in-app SVG marks. The test now checks that a public link draws an icon and that no host, public or private, ever renders an<img>. That keeps the privacy guarantee.Skill Review. Show details. The fork's shared chip registry (fix(web): context chips share one registry-owned hover preview #369) buildsSkill, Review. Show details, the label the other fork tests already use.Test-only change.
vp test run src/components/ChatMarkdown.browser.test.tsx: 15/15 pass.Follow-up to the #513 sync.
Done with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code