Repository navigation
fix: repair checks exposed by upstream sync - #517
Merged
adampeterhiggins merged 1 commit intoOct 30, 2026
Merged
Conversation
7 tasks done
adampeterhiggins
force-pushed
the
t3code/sync-upstream-2026-10-30-check-fixes
branch
from
October 30, 2026 10:20
9a8d45a to
944c3ad
Compare
adampeterhiggins
deleted the
t3code/sync-upstream-2026-10-30-check-fixes
branch
October 30, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream sync exposes existing check failures and macOS fixture assumptions: a Codex replay helper inserts request IDs into notifications and hides the resulting stream failure, a long driver module comment fails the comment rule, and the scheduled-task draft effect lacks its required synchronization reason. Claude skill discovery and launcher fixtures also expect uncanonicalized temporary paths, while the new upstream worktree-folder test makes the same assumption.
Only rewrite replay IDs on frames that already carry an ID, propagate replay event-stream failures to the awaited terminal Deferred, shorten the driver comment, and state why the mounted editor consumes the external pending draft. Combine the three text-generation test layers into a single provision; existing Effect composition warnings otherwise make server typecheck exit with code 2. Canonicalize the affected fixture paths so they compare the same paths that Node and Git return, preserving the deliberate lexical-path test in Claude discovery.
Follow-up to merged #516. Rebased onto
mainatf005059f0e214af2d242adf8a45e063e7425445c; this PR contains only the check repairs. The rebase leaves the verified file tree unchanged.Verification:
turn/startednotification.check:changedagainstorigin/main: PASS. 4,915 tests passed / 7 existing skips; 39 affected package typechecks, 133 selected React Compiler cases, format/lint, both knip passes, GraphQL and patch checks all passed.Model: GPT-6.1 Sol. Harness: Codex in T3 Code.