Skip to content

fix: repair checks exposed by upstream sync - #517

Merged
adampeterhiggins merged 1 commit into
mainfrom
t3code/sync-upstream-2026-10-30-check-fixes
Oct 30, 2026
Merged

adampeterhiggins merged 1 commit into
mainfrom
t3code/sync-upstream-2026-10-30-check-fixes

Conversation

@adampeterhiggins

@adampeterhiggins adampeterhiggins commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

The upstream sync exposes existing check failures and macOS fixture assumptions: a Codex replay helper inserts request IDs into notifications and hides the resulting stream failure, a long driver module comment fails the comment rule, and the scheduled-task draft effect lacks its required synchronization reason. Claude skill discovery and launcher fixtures also expect uncanonicalized temporary paths, while the new upstream worktree-folder test makes the same assumption.

Only rewrite replay IDs on frames that already carry an ID, propagate replay event-stream failures to the awaited terminal Deferred, shorten the driver comment, and state why the mounted editor consumes the external pending draft. Combine the three text-generation test layers into a single provision; existing Effect composition warnings otherwise make server typecheck exit with code 2. Canonicalize the affected fixture paths so they compare the same paths that Node and Git return, preserving the deliberate lexical-path test in Claude discovery.

Follow-up to merged #516. Rebased onto main at f005059f0e214af2d242adf8a45e063e7425445c; this PR contains only the check repairs. The rebase leaves the verified file tree unchanged.

Verification:

  • Before: allowance-stop replay timed out; diagnostic harness exposed the incorrectly identified turn/started notification.
  • After: full Codex adapter suite, 118/118 tests passed.
  • Focused format/lint and precommit format/lint/knip passed.
  • Full selected non-browser sync batch: 4,909 tests passed; its three remaining macOS path failures were then corrected and verified in their focused suites.
  • Complete combined-stack non-browser check:changed against origin/main: PASS. 4,915 tests passed / 7 existing skips; 39 affected package typechecks, 133 selected React Compiler cases, format/lint, both knip passes, GraphQL and patch checks all passed.
  • Test subprocesses excluded browser/render projects with a temporary guard; the normal config was restored and the working tree is clean.
  • No behavior or UI layout change; no browser/device runtime verification.

Model: GPT-6.1 Sol. Harness: Codex in T3 Code.

Base automatically changed from t3code/sync-upstream-2026-10-30-0930 to main October 30, 2026 10:19
@adampeterhiggins
adampeterhiggins force-pushed the t3code/sync-upstream-2026-10-30-check-fixes branch from 9a8d45a to 944c3ad Compare October 30, 2026 10:20
@adampeterhiggins
adampeterhiggins merged commit 44eb5bd into main Oct 30, 2026
@adampeterhiggins
adampeterhiggins deleted the t3code/sync-upstream-2026-10-30-check-fixes branch October 30, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant