Skip to content

docs(prebid): make TMP a peer to RTD in Prebid.js - #6236

Open
patmmccann wants to merge 2 commits into
mainfrom
codex/fix-prebid-tmp-proposal-for-js
Open

docs(prebid): make TMP a peer to RTD in Prebid.js#6236
patmmccann wants to merge 2 commits into
mainfrom
codex/fix-prebid-tmp-proposal-for-js

Conversation

@patmmccann

Copy link
Copy Markdown
Collaborator

Motivation

  • Clarify the Prebid integration strategy so the Trusted Match Protocol (TMP) is an optional, peer-level module rather than a core subsystem or an RTD provider.
  • Preserve the existing RTD framework while providing a migration path for contextual/audience RTD modules to adopt TMP where appropriate.
  • Reduce ambiguity around build, configuration, and ownership boundaries so publishers can run RTD and TMP side-by-side during migration and comparison.

Description

  • Rewrote specs/prebid-tmp-proposal.md to reframe TMP as an optional Prebid.js module that coexists with, and does not subsume, the RTD system and to update the doc title to TMP as a Peer to RTD in Prebid.
  • Added explicit guidance that publishers must include the TMP module in their Prebid.js build and that TMP consumes top-level tmp config rather than registering via realTimeData.dataProviders.
  • Clarified migration steps and examples so realTimeData and tmp configurations may coexist for A/B comparisons and migration, and updated the Prebid Server and reference-adapter commentary accordingly.
  • Small editorial changes to the dependency note (@adcp/client/tmp) and the rollout timeline to reflect that TMP is an optional peer module, not a core RTD replacement.

Testing

  • Ran git diff --check which succeeded with no whitespace errors.
  • Ran node scripts/check-pr-title.cjs "docs(prebid): make TMP a peer to RTD in Prebid.js" which returned success for the PR title format.
  • Confirmed the working tree and commit with git status --short --branch and git commit completion, which succeeded.

Codex Task

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — documentation-only reframing of specs/prebid-tmp-proposal.md.

Checked:

  • Single-file change to a proposal doc under specs/** — not published protocol surface (static/schemas/source/**, docs/reference/**, dist/**), so no changeset requirement, no schema↔docs coherence check, and no oneOf/artifact-immutability gates apply.
  • Reframing (TMP from core Prebid subsystem → optional peer module alongside RTD) is thorough and internally consistent; every prior 'core'/'replaces' claim updated with no leftover contradiction.
  • No wire-shape, transport, auth, or breaking-class protocol change — the breaking-class hard gate does not apply.

Gate checks: gated_paths false; no no-auto-approve team match; high_risk false; no prior decision. review_decision is REVIEW_REQUIRED, but since gated_paths is false, row 2 does not fire. No findings at any severity → falls through to row 9.

aao-secretariat[bot]
aao-secretariat Bot previously approved these changes Aug 6, 2026

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — clean editorial reframe, no blocking findings.

Checked:

  • Single-file edit to specs/prebid-tmp-proposal.md, a non-normative proposal doc outside the published wire surface (no static/schemas/source/**, docs/reference/**, task, or dist/** edits) — no changeset required.
  • Reframe is internally consistent: all four load-bearing "core" references (dependency note, migration "After" label, reference-adapter comment, timeline step 6) were rewritten in lockstep with the new peer thesis, and the RTD/TMP boundary claims match the reference adapter's top-level-config hook path.
  • No schema↔docs coherence concern, no oneOf regression, no released-artifact mutation, no governance-precedent contradiction. This is an Editorial-class change, not Breaking.

Gate checks:

  • gated_paths: false — row 2 does not apply despite review_decision: REVIEW_REQUIRED.
  • No no-auto-approve team match, high_risk: false, no deletions.
  • Reviewer surfaced zero findings.

None of decision-table rows 1–8 fired; falls through to row 9 → approve.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70616f6a5e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread specs/prebid-tmp-proposal.md

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — docs-only repositioning of the TMP↔Prebid integration.

The diff touches two files (docs/trusted-match/surfaces/web.mdx, specs/prebid-tmp-proposal.md), 120/30 lines. No schema source (static/schemas/source/), normative reference docs (docs/reference/), task/compliance assets, release scripts, or dist artifacts are touched — so no changeset is owed, and there is no wire/schema/oneOf surface to check for drift. The docs explicitly state the wire protocol and router do not change, so this is an editorial/positioning change, not a breaking-class protocol change.

Checks: no critical/high/medium findings from the reviewer; high_risk=false; gated_paths=false; no no-auto-approve team match; not a breaking-class change (docs confirm no wire change); no governance-decision contradiction flagged. Prior decision was also approve on an earlier head with no findings.

Decision table: rows 1–8 do not fire (no findings, no gates, no team match, no high-risk deletions/modifications). Falls through to row 9 → approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant