Preserve committed publication recovery failures - #3427
Open
eanz17 wants to merge 7 commits into
Open
Conversation
…-08-12_committed-publication-rollout-recovery
…-08-12_committed-publication-rollout-recovery
…-08-12_committed-publication-rollout-recovery
…-08-12_committed-publication-rollout-recovery
…-08-12_committed-publication-rollout-recovery # Conflicts: # docs/contracts/nyxid-assistant-conformance/v1/sources.json
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## feature/integrate #3427 +/- ##
===================================================
Coverage 84.53% 84.54%
===================================================
Files 1536 1537 +1
Lines 149899 150131 +232
Branches 18191 18202 +11
===================================================
+ Hits 126722 126930 +208
- Misses 14835 14853 +18
- Partials 8342 8348 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and solution
A workflow run can finish its steps successfully but fail while publishing the committed terminal state across a rollout. The recovery path treated that infrastructure failure as a completed run, which made committed Observatory state contradict the publication outcome.
This change preserves publication adapter failures as terminal infrastructure failures, makes the failure policy explicit, and covers both the execution boundary and fork-on-failure recovery behavior. It also refreshes the NyxID conformance source pin required by the current feature/integrate baseline.
Impact paths
Verification
Production acceptance
Production remains on image b58156d, which does not contain the fix. Final acceptance requires deployment followed by a newer owner committed run; the existing HR-01 failure is intentionally not closed by this PR.