re-assemble micro-VM assets when version pins move - #1022
Open
sfunkenhauser wants to merge 1 commit into
Open
Conversation
install-microvm-deps.sh decided whether to run assemble.sh by testing only whether the five asset filenames existed in $OUT. Those names don't change when a version pin moves, so an asset dir built before a bump looks complete while holding the old bytes.
sfunkenhauser
force-pushed
the
mvm_asset_check
branch
from
August 17, 2026 23:11
e96dea1 to
df647ec
Compare
Benjamin Elder (BenTheElder)
self-requested a review
August 18, 2026 01:35
sfunkenhauser
marked this pull request as ready for review
August 18, 2026 12:22
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install-microvm-deps.sh decided whether to run assemble.sh by testing only whether the five asset filenames existed in $OUT. Those names don't change when a version pin moves, so an asset dir built before a bump looks complete while holding the old bytes.