Update ActorTemplate substrate resource definition per latest discussion - #1026
Merged
Julian Gutierrez Oschmann (juli4n) merged 5 commits intoAug 18, 2026
Merged
Conversation
Julian Gutierrez Oschmann (juli4n)
approved these changes
Aug 18, 2026
Julian Gutierrez Oschmann (juli4n)
merged commit Aug 18, 2026
9edf65f
into
agent-substrate:main
11 checks passed
| string actor_template_name = 3; | ||
|
|
||
| ObjectRef actor_template_version = 13; | ||
| // TODO: replace with full actor_template spec if we decide to make each Actor self-contained. |
Collaborator
There was a problem hiding this comment.
If we are going to do this, is actor scheduling still depends on the ActorTemplate's spec's worker_selector? or it will only depends on Actor's self contained ActorTemplateSpec.worker_selector?
Will we still keep actor itself's worker_selector? (line 217)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #477